AS/Verifier: fix the report/init data comparation #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialez0
reviewed
Jan 3, 2024
Xynnn007
force-pushed
the
fix-as-data-comp
branch
from
04f9999 to
d9c0cfb
Compare
We used to compare the runtime/init data without caring about the length of each other. This commit resize the input expected data by trim or append '\0' to the equal length with the actual value from the one in evidence. In this way we can avoid unexpected failures. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-as-data-comp
branch
from
d9c0cfb to
41ad4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to compare the runtime/init data without caring about the length of each other. This commit resize the input expected data by trim or append '\0' to the equal length with the actual value from the one in evidence.
In this way we can avoid unexpected failures.
The error was firstly caught in enclave-cc's CI https://github.com/confidential-containers/enclave-cc/actions/runs/7299054486/job/20112097547?pr=312