Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add default user for git rebase #314

Merged

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Feb 1, 2024

On a github runner rebases might fail because there is no git user configured.

image

Adopted a fix from the CAA repo:

https://github.com/confidential-containers/cloud-api-adaptor/blob/a326448163882740fbaf25ceb1b16dafa784636c/hack/ci-helper.sh#L14C1-L19C2

On a github runner rebases might fail because there is no git user
configured.

Adopted a from the CAA repo:

https://github.com/confidential-containers/cloud-api-adaptor/blob/a326448163882740fbaf25ceb1b16dafa784636c/hack/ci-helper.sh#L14C1-L19C2

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke requested a review from sameo as a code owner February 1, 2024 10:44
@mkulke mkulke force-pushed the mkulke/add-rebase-default-user branch from b3fd903 to 1c24e1a Compare February 1, 2024 10:48
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkulke mkulke merged commit e48750d into confidential-containers:main Feb 2, 2024
10 checks passed
@mkulke mkulke deleted the mkulke/add-rebase-default-user branch February 2, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants