Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set certs/key as makefile deps in e2e test #325

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Feb 14, 2024

token-cert-chain.pem, ca-cert.pem and token-key.pem are specified in the configfiles. Without them a launch of kbs or resource-kbs will fail. Hence they are added as dependencies in the Makefile.

@mkulke mkulke requested a review from sameo as a code owner February 14, 2024 16:58
@mkulke mkulke force-pushed the mkulke/add-token-dependencies-to-e2e-makefile branch from 0d4398a to 356b236 Compare February 14, 2024 17:47
token-cert-chain.pem, ca-cert.pem and token-key.pem are specified in the
configfiles. Without them a launch of kbs or resource-kbs will fail.
Hence they are added as dependencies in the Makefile.

the cargo lockfile has been regenerated to fix a compilation issue on
rust nightly.

Signed-off-by: Magnus Kulke <[email protected]>

Signed-off-by: Magnus Kulke <[email protected]>
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkulke mkulke force-pushed the mkulke/add-token-dependencies-to-e2e-makefile branch 2 times, most recently from 83464a1 to d0fd3e1 Compare February 16, 2024 07:48
@mkulke mkulke merged commit f753276 into confidential-containers:main Feb 16, 2024
14 checks passed
@mkulke mkulke deleted the mkulke/add-token-dependencies-to-e2e-makefile branch February 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants