Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix repo name from kbs to Trustee #337

Merged
merged 1 commit into from
Feb 29, 2024
Merged

docs: fix repo name from kbs to Trustee #337

merged 1 commit into from
Feb 29, 2024

Conversation

Xynnn007
Copy link
Member

This commit is for the name-changing of kbs repo.

Related to #250

@Xynnn007 Xynnn007 requested a review from sameo as a code owner February 23, 2024 04:49
@Xynnn007
Copy link
Member Author

Well. The link check must fail as we haven't change the repo name for now.

@Xynnn007 Xynnn007 force-pushed the fix-document-rename-repo branch from cfefd4b to 13f7270 Compare February 23, 2024 08:02
mkulke
mkulke reviewed Feb 24, 2024
View reviewed changes
Copy link
Contributor

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest we drop the capitalization and technical labels (url, crates identifier, directories). doesn't harm probably, but it's odd

@Xynnn007
Copy link
Member Author

i suggest we drop the capitalization and technical labels (url, crates identifier, directories). doesn't harm probably, but it's odd

I got your point about capitalization. What does "technical labels" mean? Could you help to give a suggested fix example?

@mkulke
Copy link
Contributor

mkulke commented Feb 26, 2024

i suggest we drop the capitalization and technical labels (url, crates identifier, directories). doesn't harm probably, but it's odd

I got your point about capitalization. What does "technical labels" mean? Could you help to give a suggested fix example?

ah, by "technical label" I mean everything but text (e.g. in markdown), but urls, crates, folders should all be trustee IMO, not Trustee.

@Xynnn007 Xynnn007 force-pushed the fix-document-rename-repo branch from 13f7270 to 7bd4a52 Compare February 26, 2024 07:08
@Xynnn007
Copy link
Member Author

@mkulke Updated.

mkulke
mkulke approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fitzthum
fitzthum approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but looks good in general

attestation-service/docs/grpc-as.md Outdated Show resolved Hide resolved
attestation-service/docs/restful-as.md Outdated Show resolved Hide resolved
@Xynnn007
docs: fix repo name from kbs to Trustee
dc4b562 
This commit is for the name-changing of kbs repo.

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007 Xynnn007 force-pushed the fix-document-rename-repo branch from 7bd4a52 to dc4b562 Compare February 28, 2024 01:41
@Xynnn007
Copy link
Member Author

Hi folks, I've fixed due to suggestions. Maybe we can merge this together with the name changing?

@fitzthum fitzthum merged commit 9b8ef6c into confidential-containers:main Feb 29, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzthum fitzthum fitzthum approved these changes

@mkulke mkulke mkulke approved these changes

@sameo sameo Awaiting requested review from sameo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xynnn007 @mkulke @fitzthum