Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifeir: Add support for TDX quote v5 #354

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

Xynnn007
Copy link
Member

@Xynnn007 Xynnn007 commented Mar 22, 2024

Intel DCAP defines two different formats of quotes, s.t. v4 and v5.

Current implementation only supports v4 and if we get a v5 quote it will parse the wrong fields like report_data. This PR mainly add support for v5 and they both can be supported by runtime parsing. Also adds a unit test and doc update.

Fixes #352

cc @jialez0 @arronwy

@Xynnn007 Xynnn007 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 22, 2024
@Xynnn007 Xynnn007 force-pushed the feat-tdx-quote-v5 branch from 09fb640 to 4185461 Compare March 22, 2024 09:50
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but maybe an Intel person should take a look as well.

@Xynnn007 Xynnn007 force-pushed the feat-tdx-quote-v5 branch from 4185461 to 1364fc7 Compare March 26, 2024 02:46
@Xynnn007
Copy link
Member Author

Fixed lint error

Copy link
Member

@arronwy arronwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xynnn007 LGTM!

@Xynnn007 Xynnn007 merged commit 5536af5 into confidential-containers:main Mar 28, 2024
16 checks passed
@Xynnn007 Xynnn007 deleted the feat-tdx-quote-v5 branch March 28, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AS/Verifier: TDX Quote format updation
3 participants