Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings #360

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

fitzthum
Copy link
Member

@fitzthum fitzthum commented Apr 3, 2024

Fix two of the build warnings that we typically get.

  1. Force all the workspace members to use the resolver 2
  2. Set default-features to false for jsonwebtoken in the root Cargo file so that package members can use it with default-features set to false as well.

We still have a bunch of warnings involving duplicate package names, but I don't think we can fix these within our project.

Force use of resolve 2 and allow workspace members
to set no-default-features for jsonwebtoken

Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
@fitzthum fitzthum requested a review from sameo as a code owner April 3, 2024 21:38
@fitzthum fitzthum merged commit 572ebd0 into confidential-containers:main Apr 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants