Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy the readme and documents #365

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

Xynnn007
Copy link
Member

The user-oriented documents have been organized and duplicate parts have been deleted to make them more organized. These tasks will help the CoCo home page documentation.

Hope this helps @surajssd

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but this generally looks good.

I wonder if the grpc and ttrpc servers really need separate docs. Either way is fine with me.

attestation-service/README.md Show resolved Hide resolved
attestation-service/README.md Show resolved Hide resolved
attestation-service/docs/restful-as.md Outdated Show resolved Hide resolved
attestation-service/docs/restful-as.md Outdated Show resolved Hide resolved
@Xynnn007
Copy link
Member Author

@surajssd Added some detailed guides, ptal

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of my grpc-as.md comments are relevant for restful-as.md as well

attestation-service/docs/grpc-as.md Outdated Show resolved Hide resolved
attestation-service/docs/grpc-as.md Outdated Show resolved Hide resolved
Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise this looks good to me @Xynnn007 Thanks.

@Xynnn007 Xynnn007 force-pushed the fix-doc branch 2 times, most recently from 6335ae8 to a66e9f2 Compare April 19, 2024 02:22
@Xynnn007
Copy link
Member Author

I hope all works. PTAL @surajssd @mythi

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xynnn007 Xynnn007 merged commit 26a1527 into confidential-containers:main Apr 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants