Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Use Ubuntu 22.04 as kbs base image #368

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Apr 17, 2024

related to: #153

When using debian:stable-slim as a base image the sgx verification libraries will crash when attempting to fetch an sgx collateral during td quote validation.

Using Ubuntu 22.04 as a base image fixes the crash, and is consistent with AS which uses the same base image.

(discussion here)

Also removed the tdx attest lib which is not required for verification and pointed the sgx repo to the correct ubuntu version.

related-to: confidential-containers#153

When using debian:stable-slim as a base image the sgx verification
libraries will crash when attempting to fetch an sgx collateral during
td quote validation.

Using Ubuntu 22.04 as a base image fixes the crash, and is consisten
with the AS which uses same base image.

Signed-off-by: Magnus Kulke <[email protected]>
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I wonder if it was good to have L14 aligned?

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit ee1a8ce into confidential-containers:main Apr 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants