Add a helper script for releasing trustee #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Cool PR! Thanks @portersrc I am ok with the image push parts.
cc @surajssd
portersrc
force-pushed
the
trustee-helper-release-script
branch
2 times, most recently
from
a8c2f94 to
49912e1
Compare
fitzthum
reviewed
Apr 23, 2024
hack/release-helper.sh
Outdated
| echo " -k A github token with permissions on trustee to write packages" | ||
| echo " and open PRs." | ||
| echo " -c This is the tag that's been tested and that you're happy with." | ||
| echo " You want to release from this tag. Example: latest" |
There was a problem hiding this comment.
Does it have to be a tag or could it be a commit sha?
There was a problem hiding this comment.
Oh 🤔 good point. Ultimately the candidate-release-tag is used like so:
docker pull ${ghcr_repo}/${staged_pkg_name}:${candidate_release_tag}
E.g. for kbs:
docker pull ghcr.io/confidential-containers/staged-images/kbs:dc01f454264fb4350e5f69eba05683a9a1882c41
So it must be a tag for a GHCR package, but because we use commit shas for tagging our packages -- well -- a commit sha can be used. Let me update to make it clearer.
There was a problem hiding this comment.
Ok, adopted your language suggestion here b/c it's better, I think. Thanks!
Signed-off-by: Chris Porter <[email protected]>
portersrc
force-pushed
the
trustee-helper-release-script
branch
from
49912e1 to
2a414e3
Compare
fitzthum
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bash script to help trustee maintainers perform releases. As the release guide changes, this script can/should change along with it.
This work follows from discussions for trustee's release process, e.g. see here. It is also similar in spirit to the one in peer pods here.
Example usage: