Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opa: Refactor opa module errors #409

Conversation

kartikjoshi21
Copy link
Contributor

Fixes: #394

Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. I think we need cargo fmt to make lint checker happy.

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but gotta fixup the linter

@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/error-opapolicy branch from 4620998 to 1471acd Compare June 16, 2024 07:01
@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/error-opapolicy branch from 1471acd to cc55b51 Compare June 18, 2024 04:07
@kartikjoshi21 kartikjoshi21 requested a review from mkulke June 18, 2024 04:11
@kartikjoshi21 kartikjoshi21 force-pushed the kartikjoshi21/error-opapolicy branch from cc55b51 to 48068c2 Compare June 24, 2024 05:33
@Xynnn007 Xynnn007 merged commit 3ce9302 into confidential-containers:main Jun 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AS: PolicyEngine should differentiate user and internal errors
4 participants