ci: added publishing intel trust authority AS docker

[pawelpros]

• Refactored directory structure for building KBS docker images
• Added publishing KBS intel trust authority AS docker image on ghcr.io

[fitzthum]

DCO check complains because the author does not match the sign-off. Basically it should match git config --local user.name. You can update that config and then do git commit --amend --reset-author I think.

[fitzthum]

You should probably update the release script to make sure your staged image gets copied over as a release image.

[pawelpros]

Thanks for the tip - should be ok right now - I have also aligned with recent changes

[fitzthum]

Looks fine. I don't see anything bumping OpenSSL

Also note that we use the same naming convention for Dockerfiles in the AS dir. Do we care about this being consistent?

[fidencio]

For change 1.

Why are we re-structuring the directories? What's the clear benefit of this new method over the older one?

I'd mostly be interested on whether you hit some issue with the current status of things, or not.

This kind of changes, unless those are fully triggered from the Makefile, deserve a release notes entry, as it changes files location that packagers may rely on.

[fidencio]

Change 2 is good, but I'd recommend doing it as part of its own commit(s).

[fidencio]

Now, about the change 3, which also deserves to be part of its own commit (still on this very same PR).

We're adding the possibility to build the ITA image, but ... correct me if I'm mistaken ... I think we're doing multi-arch build for all the images. With this in mind, an obvious question is ... is ITA supposed to support multi-arch? Or is it x86_64 specific?

Depending on the answer, we may have to limit this to only be built with for x86_64.

[fidencio]

lgtm, thanks @pawelpros!

[fitzthum]

LGTM