Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibmse: add debug_assertions for debug and release branch #418

Closed
wants to merge 0 commits into from
Closed

ibmse: add debug_assertions for debug and release branch #418

wants to merge 0 commits into from

Conversation

huoqifeng
Copy link
Contributor

@huoqifeng huoqifeng commented Jun 14, 2024 •
edited
Loading

Add #[cfg(debug_assertions)] to make sure non-release code never built in release build

fitzthum
fitzthum reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I might prefer if you kept the env var but only had it be an option in the debug case rather than always skipping verification in the debug builds.

@huoqifeng huoqifeng closed this Jun 17, 2024
@huoqifeng huoqifeng deleted the ibmse-debug branch June 17, 2024 01:59
@huoqifeng huoqifeng mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzthum fitzthum fitzthum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huoqifeng @fitzthum