Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime dependencies to Dockerfile.rhel-ubi #422

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

spotlesstofu
Copy link
Contributor

Follow-up to #403. Add runtime dependencies, as pointed out by @mythi. Also changes the builder image from Fedora to CentOS Stream.

FROM registry.access.redhat.com/ubi9

# Install runtime dependencies from Intel repo.
COPY --from=builder /root/sgx_rpm_local_repo /root/sgx_rpm_local_repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps remove the local repo after the necessary packages are installed to reduce the final image size a bit?

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but completely untested from my side

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 48c5b98 into confidential-containers:main Jun 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants