Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibmse: use optional root_ca when launch kbs #423

Merged
merged 2 commits into from
Jun 24, 2024
Merged

ibmse: use optional root_ca when launch kbs #423

merged 2 commits into from
Jun 24, 2024

Conversation

huoqifeng
Copy link
Contributor

  • Make root_ca optional
  • Check certs offline by default

@huoqifeng huoqifeng marked this pull request as draft June 19, 2024 01:35
ibmse: use optional root_ca when launch kbs
d348296 
- Make root_ca optional
- Check certs offline by default
- Corrected the doc

Signed-off-by: Qi Feng Huo <[email protected]>
@huoqifeng
Copy link
Contributor Author

@Xynnn007 @fitzthum may I ask your help to review this?

@huoqifeng huoqifeng marked this pull request as ready for review June 21, 2024 08:09
Xynnn007
Xynnn007 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. btw do you want this commit be included in the incoming release?

@huoqifeng
Copy link
Contributor Author

lgtm. btw do you want this commit be included in the incoming release?

@Xynnn007 Yes. Thanks!

ibmse: make offline_certs_verify configurable
f8db6fb 
- Make offline_certs_verify configurable

Signed-off-by: Qi Feng Huo <[email protected]>
liudalibj
liudalibj approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fitzthum
fitzthum approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. One small question.

attestation-service/verifier/src/se/ibmse.rs Show resolved Hide resolved
@Xynnn007 Xynnn007 merged commit e3ad5e2 into confidential-containers:main Jun 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liudalibj liudalibj liudalibj approved these changes

@Xynnn007 Xynnn007 Xynnn007 approved these changes

@fitzthum fitzthum fitzthum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huoqifeng @fitzthum @Xynnn007 @liudalibj