dep/verifier: fix eventlog with extra blank chars #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to definition of AAEL, a ' ' is allowed as part of content field. Thus we now parse the original eventlog string using ' ' as separator to distinguish domain, operation and content only twice, and the things left are treated as the content of the eventlog, including extra ' 's. Signed-off-by: Xynnn007 <[email protected]>
mkulke
reviewed
Aug 2, 2024
yea, I think you raise really good points that we do not have a spec for the eventlog format. Initially I think it should be letters and numbers, the domain/operation should not have any blanks. Maybe we should make an issue to sync a spec for this, and then publish it on CoCo website due to confidential-containers/confidential-containers#225 (comment) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to definition of AAEL, a ' ' is allowed as part of content field. Thus we now parse the original eventlog string using ' ' as separator to distinguish domain, operation and content only twice, and the things left are treated as the content of the eventlog, including extra ' 's.