-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verifier: Use the VirTEE CA Chain #446
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ byteorder = "1" | |
cfg-if = "1.0.0" | ||
codicon = { version = "3.0", optional = true } | ||
# TODO: change it to "0.1", once released. | ||
csv-rs = { git = "https://github.com/openanolis/csv-rs", rev = "b74aa8c", optional = true } | ||
csv-rs = { version = "=0.1.0", git = "https://github.com/openanolis/csv-rs", rev = "b74aa8c", optional = true } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this intentionally both version and ref? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure if it is a bug in Cargo, or something else, but if I didn't enforce the specific version of the crate, it was being mangled on re-build. |
||
eventlog-rs = { version = "0.1.3", optional = true } | ||
hex.workspace = true | ||
jsonwebkey = "0.3.5" | ||
|
@@ -41,9 +41,9 @@ scroll = { version = "0.11.0", default-features = false, features = ["derive"], | |
serde.workspace = true | ||
serde_json.workspace = true | ||
serde_with = { workspace = true, optional = true } | ||
sev = { version = "3.1.1", features = ["openssl", "snp"], optional = true } | ||
sev = { version = "4.0.0", features = ["openssl", "snp"], optional = true } | ||
sha2.workspace = true | ||
tokio = { workspace = true, optional = true, default-features = false } | ||
tokio = { workspace = true, optional = true } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we want to turn on the tokio default-features? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, I am not sure. in this case, I am just removing the ignored |
||
intel-tee-quote-verification-rs = { git = "https://github.com/intel/SGXDataCenterAttestationPrimitives", tag = "DCAP_1.21", optional = true } | ||
strum.workspace = true | ||
veraison-apiclient = { git = "https://github.com/chendave/rust-apiclient", branch = "token", optional = true } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we want to turn on the tokio default-features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any clear insight into why the project chose to have full tokio features enabled. The PR moves the
default-features = false
into the workspace toml. If we have it inside of the verifierCargo.toml
, it is completely ignored, and it throws a warning.