attestation-service: Allow conditional compilation of some features #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verifier/all-verifier option is already enabled with the default build. Yet, if a user wants to optionally compile with a subset of verifiers, they cannot due so unless disabling the all-verifier feature in the dependency. Signed-off-by: Tyler Fanelli <[email protected]>
Supplying a FEATURES argument to the attestation service's Makefile can
conditionally compile features into the build. The FEATURES argument
will disable default features and instead supply the selected features.
For example `FEATURES=restful-bin,rvps-grpc,snp-verifier make grpc-as`
will expand to:
cargo build --bin grpc-as --release \
--no-default-features \
--features grpc-bin,restful-bin,rvps-grpc,snp-verifier
Signed-off-by: Tyler Fanelli <[email protected]>
mkulke
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile is a bit strict on conditional compilation. Add some conditional verifier compilation in
Cargo.tomland introduce a new configurableFEATURESvariable to specify feature compilation other than default features.