gha: Add image build check for s390x #576
Conversation
BbolroC
force-pushed
the
add-image-build-check-s390x
branch
from
4551382 to
40031e8
Compare
| @@ -0,0 +1,84 @@ | |||
| name: Build CoCo AS/RVPS Image | |||
There was a problem hiding this comment.
The name here is different from as-docker-build.yml's. What would this cause? idk do we need to make them the same?
There was a problem hiding this comment.
Hmm.. To my best knowledge, a title of the called workflow does not appear on an action section. I prefer to having a different title for each workflow. 😉
| with: | ||
| build_option: |
There was a problem hiding this comment.
same here, let's make the build_option not required, so we can skip this
Issue confidential-containers#568 highlights the need for an image build check for s390x, similar to what we have for x86_64. This commit addresses the need by: - Extracting the image build steps from the push-{kbs,as}-image-to-ghcr workflow into separate workflows - Configuring these workflows to run on PR events or after merging a PR Notable change: - On merge, the workflow now pushes `ghcr.io/confidential-containers/staged-images/rhel-ubi` Signed-off-by: Hyounggyu Choi <[email protected]>
BbolroC
force-pushed
the
add-image-build-check-s390x
branch
from
40031e8 to
b65d78a
Compare
|
It seems that two workflows (e.g., one triggered on merge and another on PR events) are being executed when the PR is merged. This results in a duplicate image build step, similar to what we observed in the guest-components repository. I will create a follow-up PR similar to the following to deduplicate the image build process:
Thanks. This behaviour is not something this PR has introduced. The docker build check workflow has been called on merge together with the build-and-push workflow like: https://github.com/confidential-containers/trustee/actions/runs/11854184038/job/33035819254 |
Issue #568 highlights the need for an image build check for s390x, similar to what we have for x86_64.
This PR addresses the need by:
Notable change:
ghcr.io/confidential-containers/staged-images/rhel-ubiThe changes on PR events have been verified with:
The changes on merge needs to be verified after merging this PR. I will keep an eye on how it goes and bring things up immediately when something goes wrong. Thanks.
Signed-off-by: Hyounggyu Choi [email protected]