Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: consolidate matrix configurations #580

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Nov 15, 2024

The current matrix configurations are more like an manual enumeration of build options expressed in verbose matrix/include/exclude statement.

The PR changes this into a simple matrix of the build and then use include to add required auxiliary fields to each of the valid matrix combinations.

(the kbs workflow already follows the same scheme)

@mkulke mkulke requested a review from a team as a code owner November 15, 2024 11:43
@mkulke mkulke force-pushed the mkulke/consolidate-matrix-configurations branch from a84b106 to ce09679 Compare November 15, 2024 14:55
Copy link
Member

@BbolroC BbolroC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much nicer and more readable, thanks @mkulke !

The current matrix configurations are more like an manual enumeration of
build options expressed in verbose matrix/include/exclude statement.

The PR changes this into a simple matrix of the build and then use include
to add required auxiliary fields to each of the valid matrix combinations.

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke force-pushed the mkulke/consolidate-matrix-configurations branch from ce09679 to b835f0f Compare November 15, 2024 15:18
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BbolroC BbolroC merged commit 828140d into confidential-containers:main Nov 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants