Added checks for AS and KBS policy setting #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jialez0
force-pushed
the
policy-check
branch
10 times, most recently
from
818b092 to
d7a9097
Compare
Signed-off-by: Jiale Zhang <[email protected]>
jialez0
force-pushed
the
policy-check
branch
from
d7a9097 to
af0defd
Compare
Xynnn007
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current KBS and AS set policy interfaces, there is no validity check for policies, which can result in policies with syntax errors being successfully set and causing errors when subsequently calling the evaluation API. This is not helpful for policy setters to promptly identify errors. This PR adds policy validity checks to the KBS and AS set policy interfaces to avoid the aforementioned issues.