Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attaching sources jar #191

Closed
wants to merge 1 commit into from
Closed

Conversation

NersesAM
Copy link

Sources jar are missing from maven repo which makes it hard to debug in IDE when sources for given version can be downloaded with one click, whereas now one has to go clone github repo and attach sources manually.
example:
http://packages.confluent.io/maven/io/confluent/kafka-avro-serializer/5.2.1/kafka-avro-serializer-5.2.1.jar <- works great
http://packages.confluent.io/maven/io/confluent/kafka-avro-serializer/5.2.1/kafka-avro-serializer-5.2.1-sources.jar <- doesn't 😞

@ghost
Copy link

ghost commented Apr 14, 2019

It looks like @NersesAM hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@NersesAM
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Apr 14, 2019

@confluentinc It looks like @NersesAM just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@NersesAM NersesAM force-pushed the patch-1 branch 2 times, most recently from 2fa80b3 to b41e531 Compare April 9, 2020 17:33
@NersesAM
Copy link
Author

NersesAM commented Apr 9, 2020

Any change getting this merged?

@NersesAM
Copy link
Author

NersesAM commented Apr 9, 2020

this PR fixes #256

@OneCricketeer
Copy link

example: ... kafka-avro-serializer

Think you wanted this repo https://github.com/confluentinc/schema-registry

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NersesAM NersesAM closed this Apr 6, 2022
@NersesAM
Copy link
Author

NersesAM commented Apr 6, 2022

this has been fixed already Sources are available starting from v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants