Print actual error when trying to access registry

[herbae]

I spent three whole days trying to figure out what was wrong with my configs in a controlled environment. The problem was a simple \n character in my schema registry credentials. It would have helped a lot if I could see the HTML response from schema registry server, instead of a JSON deserializing exception.

This patch does not solve the issue described in #733, but at least prints the actual error in the stack trace. JsonDeserializer will print the source string when it's not an InputStream.

[ghost]

It looks like @herbae hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[herbae]

[clabot:check] Em ter, 10 de set de 2019 12:26, Confluent CLA Bot <[email protected]> escreveu:

…

It looks like @herbae <https://github.com/herbae> hasn't signed our *C*ontributor *L*icense *A*greement, yet. The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia <http://en.wikipedia.org/wiki/Contributor_License_Agreement> You can read and sign our full Contributor License Agreement here <http://clabot.confluent.io/cla>. Once you've signed reply with [clabot:check] to prove it. Appreciation of efforts, clabot — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1200?email_source=notifications&email_token=ABQCB2A5KBYWVNY2LEU7JRDQI64BHA5CNFSM4IVJGLI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LP5MI#issuecomment-529989297>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQCB2BMIS76C4KR5CDMB3TQI64BHANCNFSM4IVJGLIQ> .

[ghost]

@confluentinc It looks like @herbae just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[OneCricketeer]

Is the error returned to the client, or output to the server logs?

Is there any way to get it without a Scanner?

[joelezellLP]

Is anything going to happen with this MR? I just wasted days trying to diagnose a schema registry error which turned out to be a 504 gateway timeout. I'm not sure I agree with the implementation here by the way. I think the logic should be that if you get any 4xx/5xx response, you don't try to parse it as JSON. Just print the error code and raw message body.

[OneCricketeer]

The logic here seems to be processing the whole InputStream to a string via a Scanner, before actually rendering the log, but yes, using not ObjectMapper for that case, or using a Scanner instead of new String(es.readAllBytes()), would look better, IMO

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}