Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEA-scorer #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

LEA-scorer #5

wants to merge 6 commits into from

Conversation

ns-moosavi
Copy link

No description provided.

@sameer-pradhan
Copy link
Member

Merged the LEA-scorer as the similarly named branch in the main scorer.

There are few things that need to be resolved (not necessarily in that order of priority):

  1. Right now, there are two separate README files. We need to merge the README.md into README.rst.
  2. Test cases, especially edge cases specific to the LEA-scorer need to be added to ensure proper coverage.
  3. There are tabs in the modified code. There should only be spaces. Always run Perl Tidy with the following options to ensure that the code is properly formatted: perltidy -i=2 -pt=2 -bt=2 -sbt=2
  4. Create a the next pull request against the LEA-scorer branch. That way the merge will happen in the same place.

You would need to pull the modifications I made to the LEA-scorer branch on the origin (upstream) and create another pull request when some or all of these issues are resolved. I can merge the two README files, and we can plan a Skype session to discuss the second item.

One we are done with the changes and ensure that we have the necessary test cases and other issues resolved, we can can merge it into the master and increment the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants