This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the minStake and status from the GATEWAY contracts.
Previously we had this as we only have collateral based PermissionMode and the idea is to use these parameters to control in the Gateway to enforce some control over different subnets. But now we are moving towards different
PermissionMode
and these parameters no longer required.Note that
minStake
is a parameter applied to all subnets created, but forPermissionMode.Federated
, there is no collateral requirements, so aminStake
in the Gateway must be 0. Anything above zero will preventFederated
subnet to be register in the gateway. IfminStake
is always 0, just remove this parameter.At the same time,
status
will be deprecated as well as collateral alone does not manage the status of the subnet. Overall, subnets are managing their own stake requirements and status, so that the gateway does not really need to be aware of subnet’s status and status is not used anywhere except for listing subnets. Subnet’s status is managed in SubnetActor now, in bootstrapped and killed parameters, Gateway no longer needs to maintain the status.