Skip to content

Commit

Permalink
Silent pylint
Browse files Browse the repository at this point in the history
* CLOUDBLD-7690

Signed-off-by: Robert Cerven <[email protected]>
  • Loading branch information
rcerven committed Nov 10, 2021
1 parent 74e675c commit 5b78811
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion atomic_reactor/inner.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class BuildResults(object):


class BuildResultsEncoder(json.JSONEncoder):
def default(self, obj): # pylint: disable=method-hidden
def default(self, obj): # pylint: disable=method-hidden,arguments-renamed
if isinstance(obj, BuildResults):
return {
'build_logs': obj.build_logs,
Expand Down
2 changes: 1 addition & 1 deletion atomic_reactor/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import os
import sys
import traceback
import imp
import imp # pylint: disable=deprecated-module
import datetime
import inspect
import time
Expand Down
4 changes: 2 additions & 2 deletions atomic_reactor/plugins/build_orchestrate_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -695,8 +695,8 @@ def check_manifest_list(self, build_image, orchestrator_platform, platforms,
arch_digests[arch] = image_name + '@' + manifest['digest']

arch_to_platform = get_goarch_to_platform_mapping(self.workflow, self.plat_des_fallback)
for arch in arch_digests:
self.build_image_digests[arch_to_platform[arch]] = arch_digests[arch]
for arch, digest in arch_digests.items():
self.build_image_digests[arch_to_platform[arch]] = digest

# orchestrator platform is in manifest list
if orchestrator_platform not in self.build_image_digests:
Expand Down
2 changes: 1 addition & 1 deletion atomic_reactor/plugins/prepub_tests_for_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def run(config_file, image_id, logger=None, **kwargs):
"""

import os
import imp
import imp # pylint: disable=deprecated-module
import shutil
import tempfile

Expand Down
4 changes: 2 additions & 2 deletions tests/plugins/test_group_manifests.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,10 +496,10 @@ def test_group_manifests(tmpdir, schema_version, test_name, group, foreign_layer
registries_list.append(new_reg)

platform_descriptors_list = []
for platform in goarch:
for platform, arch in goarch.items():
new_plat = {
'platform': platform,
'architecture': goarch[platform],
'architecture': arch,
}
platform_descriptors_list.append(new_plat)

Expand Down
4 changes: 2 additions & 2 deletions tests/plugins/test_koji_parent.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,8 @@ def test_multiple_parent_images(self, workflow, koji_session, koji_mtype,
}
media_type = get_manifest_media_type(media_version)
workflow.builder.parent_images_digests = {}
for parent in parent_images:
dgst = parent_images[parent].tag
for parent, digest in parent_images.items():
dgst = digest.tag
workflow.builder.parent_images_digests[parent.to_str()] = {media_type: dgst}
if not koji_mtype:
media_type = get_manifest_media_type('v1')
Expand Down
4 changes: 2 additions & 2 deletions tests/plugins/test_push_floating_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -482,10 +482,10 @@ def test_floating_tags_push(tmpdir, workflow, test_name, registries, manifest_re
registries_list.append(new_reg)

platform_descriptors_list = []
for platform in goarch:
for platform, arch in goarch.items():
new_plat = {
'platform': platform,
'architecture': goarch[platform],
'architecture': arch,
}
platform_descriptors_list.append(new_plat)

Expand Down

0 comments on commit 5b78811

Please sign in to comment.