Skip to content

Commit

Permalink
.github: dependabot: Ignore pydantic-core & consider only pydantic
Browse files Browse the repository at this point in the history
pydantic and pydantic-core have different release cycles and since a
pydantic release is always locked to a particular pydantic-core
version, a dependabot update to both will cause install conflicts
pretty much every time because dependabot doesn't see transitive
dependency relations.

This patch makes it so that pydantic-core's updates are ignored by
dependabot (because it's a transitive dependency for us) and we're only
going to consider pydantic. This however, will still break installs
because pip-compile needs to be invoked to re-pin this new pydantic
version to a correct pydantic-core version. That is handled by the
newly introduced github dependabot workflow 'dependabot-pipcompile.yml'
introduced in a past patch.

Signed-off-by: Erik Skultety <[email protected]>
  • Loading branch information
eskultety committed Jan 6, 2025
1 parent 83c92e9 commit 74510b4
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,10 @@ updates:
directory: "/"
schedule:
interval: "monthly"
ignore:
- dependency-name: "pydantic-core"
groups:
minor-and-patch:
update-types:
- "minor"
- "patch"
exclude-patterns:
- "pydantic*"

# pydantic is a known violator of version updates where they don't release the core backend
# with the API library at the same time which holds up other legitimate updates, so group
# pydantic deps together
pydantic:
update-types:
- "minor"
- "patch"
patterns:
- "pydantic*"

0 comments on commit 74510b4

Please sign in to comment.