ensure packageManager is correctly set for yarn #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
reviewed
Oct 10, 2023
taylormadore
force-pushed
the
configure-yarn
branch
from
68d3be3 to
34668aa
Compare
taylormadore
changed the title
taylormadore
requested review from
brunoapimentel,
ben-alkov,
lkolacek,
fepas,
chmeliik and
ejegrova
chmeliik
reviewed
Oct 11, 2023
taylormadore
force-pushed
the
configure-yarn
branch
2 times, most recently
from
cf96dfe to
9d87887
Compare
chmeliik
reviewed
Oct 12, 2023
taylormadore
force-pushed
the
configure-yarn
branch
from
9d87887 to
b74ff6c
Compare
brunoapimentel
approved these changes
Oct 13, 2023
taylormadore
force-pushed
the
configure-yarn
branch
from
b74ff6c to
810bf15
Compare
STONEBLD-1776
Since we will rely on corepack to download and configure
the correct version of yarn for a request, ensure that
packageManager is defined in package.json.
Use either yarnPath from .yarnrc, packageManager, or a
combination of the two to set the correct yarn version.
Raise exceptions for the following cases:
- packageManager is already set, but we can't parse it
- neither yarnPath or packageManager is set (or parseable)
- the versions specified by yarnPath and packageManager
are different
Signed-off-by: Taylor Madore <[email protected]>
taylormadore
force-pushed
the
configure-yarn
branch
from
810bf15 to
007d256
Compare
|
Rebased on main |
chmeliik
approved these changes
Oct 16, 2023
Merged
via the queue into
containerbuildsystem:main
with commit Oct 16, 2023
4acb288
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on #338
STONEBLD-1776
Since we will rely on corepack to download and configure
the correct version of yarn for a request, ensure that
packageManager is defined in package.json.
Use either yarnPath from .yarnrc, packageManager, or a
combination of the two to set the correct yarn version.
Raise exceptions for the following cases:
are different
Maintainers will complete the following section