[Do not merge] Test RHTAP pipeline copy #355
Conversation
lkolacek
force-pushed
the
STONEBLd-1685
branch
4 times, most recently
from
8b911dc to
7684947
Compare
| @@ -0,0 +1,68 @@ | |||
| --- | |||
There was a problem hiding this comment.
Commenting on the commit message:
Can you be more descriptive in the commit message please? It might be obvious to all current project members at the moment what exactly this Tekton template is for or at least what's the reason behind it being added, but for new members or just irregular contributors this change is completely opaque without any context. Also rember that this commit message goes to public git history, so if you don't explain anything in the commit message, in future there's going to be literally 0 trace on why some things were done in a specific way in the template, like e.g. the 'script' YAML section.
I would also like to again suggest adopting some kind of structure in the commit subjects: e.g. .tekton: <file>: <what> or similar, because that immediately will help potential reviewers identify whether that's an area they're expert on/interested in and what the gist of suggested changes is without having to go through every commit in each (or most) PR, dive into the code to understand the changes and then figure out whether they feel qualified enough to review the changes. Please take ^this just as a mere suggestion from an observer :).
There was a problem hiding this comment.
OK I apologize I could have added some description to commit message. This PR is not meant to be merged and it's purpose is only provide some test info. Review is not needed here and it was not requested.
| - name: tag-with-latest | ||
| image: registry.access.redhat.com/ubi9/skopeo:latest@sha256:23c9ed4af1f42614bdc56309452568b2110a67f23102f42f6a6582a63b63dcdb | ||
| script: | | ||
| #!/usr/bin/env bash |
There was a problem hiding this comment.
Can you give a bit of trivia for this script? IOW what is it trying to test?
lkolacek
force-pushed
the
STONEBLd-1685
branch
6 times, most recently
from
1d773e3 to
1a42fd7
Compare
lkolacek
changed the title
lkolacek
force-pushed
the
STONEBLd-1685
branch
17 times, most recently
from
d2b3eda to
57f39f1
Compare
lkolacek
force-pushed
the
STONEBLd-1685
branch
18 times, most recently
from
ab64372 to
dfce975
Compare
This is a debug/test PR that uses custom pipelineRun via GitHub CI - RHTAP bot to test RHTAP specifics to support design preparation to avoid/undo modifications in the user’s source repository None of these changes should be merged to the main branch STONEBLD-1685 Signed-off-by: Ladislav Kolacek <[email protected]>
lkolacek
force-pushed
the
STONEBLd-1685
branch
from
dfce975 to
4ec38ca
Compare
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)