-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo design doc #441
base: main
Are you sure you want to change the base?
Cargo design doc #441
Conversation
6057428
to
5cd372b
Compare
it'll be a while before I get to read/understand/review this, but kudos for pushing the "PR for designs" way. Feels like it's going to be more ergonomic + we can not only close the PR, but also retain the doc for future reference, OR convert it to docs, i.e. it gives us a bit more flexibility. |
8ec2e18
to
3c48165
Compare
Is this ready for review ? |
All major parts are there, I will still be tweaking the document a little, but yes, it is ready for review/suggestions. |
d243406
to
9e8e42a
Compare
Now that we have ADRs in the repo, I wonder what approach we should take with these design docs. Should they just become ADRs? I feel like they're too big for an ADR, but the info here is important. Wdyt? |
docs/designs/cargo-support.md
Outdated
Dev and build dependencies have respective `kind`s when listed in the nested | ||
`.dependencies` key. To identify them and mark them as such in the SBOM, we'd | ||
need only to check all the times a single package appears as a transitive | ||
dependency in this output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To identify them and mark them as such in the SBOM, we'd
need only to check all the times a single package appears as a transitive
dependency in this output.
I am not sure if I understand this section. It looks like the same approach as for yarn classic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it essentially is.
The path for the document is slightly incorrect. |
Signed-off-by: Bruno Pimentel <[email protected]>
9e8e42a
to
d4a308a
Compare
I think keeping them in |
First iteration. Signed-off-by: Alexey Ovchinnikov <[email protected]>
d4a308a
to
50ef4f2
Compare
A design doc for implementing Cargo support. It mostly follows the general principle for other package managers. The bigger issue of having Rust-based dependencies is described in an appendix since this is not strictly Rust support.
Corresponding repository for ITs is https://github.com/cachito-testing/cachi2-rust
Maintainers will complete the following section