E2E test for RPM prefetching #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
brunoapimentel
changed the title
brunoapimentel
force-pushed
the
rpm-e2e
branch
2 times, most recently
from
d8c95df to
a2db05f
Compare
brunoapimentel
changed the title
eskultety
reviewed
Apr 12, 2024
| @@ -90,6 +90,16 @@ def build_image_for_test_case(tmp_path: Path, containerfile: str, test_case: str | |||
| "--network", | |||
| "none", | |||
| ] | |||
|
|
|||
| rpm_repos_path = f"{tmp_path}/{test_case}-output/deps/rpm/x86_64/repos.d" | |||
There was a problem hiding this comment.
Shall we add a comment note here that we should extend this to more architectures in the future when we have means of testing it?
Up to you.
There was a problem hiding this comment.
Yeah, it seems that arm runners will be a thing eventually: https://resources.github.com/devops/accelerate-your-cicd-with-arm-and-gpu-runners-in-github-actions/
Which makes me wonder if we should set https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.extra |
eskultety
approved these changes
Apr 15, 2024
taylormadore
approved these changes
Apr 15, 2024
The generated repofiles need to be mounted during the build process so that dnf can use the prefetched RPM files. This patch changes the global utils so that every time a x86_64 repos.d folder is present in a test case, it will be mounted to /etc/yum.repos.d. Signed-off-by: Bruno Pimentel <[email protected]>
Signed-off-by: Bruno Pimentel <[email protected]>
Merged
via the queue into
containerbuildsystem:main
with commit Apr 15, 2024
fdaebb5
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an e2e test that covers the following steps:
Maintainers will complete the following section