RPM PoC: Integration tests #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
brunoapimentel
force-pushed
the
rpm-integration-tests
branch
from
9f24061 to
2d21aa4
Compare
brunoapimentel
force-pushed
the
rpm-integration-tests
branch
2 times, most recently
from
a5d8fc9 to
c7a7987
Compare
brunoapimentel
requested review from
eskultety,
taylormadore,
ben-alkov,
ejegrova and
slimreaper35
|
lgtm |
eskultety
reviewed
May 13, 2024
There was a problem hiding this comment.
@brunoapimentel looks good, nothing substantial, but see my comments whether you think it's worth pursuing.
Signed-off-by: Bruno Pimentel <[email protected]>
Signed-off-by: Bruno Pimentel <[email protected]>
brunoapimentel
force-pushed
the
rpm-integration-tests
branch
from
c7a7987 to
b202631
Compare
eskultety
approved these changes
May 14, 2024
ben-alkov
approved these changes
May 14, 2024
This test prefetches RPM content and proceeds to generate the .repo file by using the `inject-files` command. Since the steps for this test differ from the usual, it was necessary to customize the test boilerplate to call `inject-files` without actually fully building the image, since only the contents of the generated .repo file need to be checked. Signed-off-by: Bruno Pimentel <[email protected]>
brunoapimentel
force-pushed
the
rpm-integration-tests
branch
from
b202631 to
cbfad69
Compare
Merged
via the queue into
containerbuildsystem:main
with commit May 14, 2024
73c5fa4
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the final scenarios:
Maintainers will complete the following section