Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn-classic: Adding user-facing docs #760

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

a-ovchinnikov
Copy link
Collaborator

This PR introduces user-facing documentation for Yarn Classic.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Docs updated (if applicable)
  • Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:

@a-ovchinnikov a-ovchinnikov force-pushed the issue635 branch 3 times, most recently from b3cbccf to 0b7c35a Compare December 2, 2024 18:19
@a-ovchinnikov a-ovchinnikov marked this pull request as ready for review December 3, 2024 14:49
docs/yarn.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
Copy link
Member

@ben-alkov ben-alkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picked a few nits, otherwise LGTM 🌮

@a-ovchinnikov a-ovchinnikov force-pushed the issue635 branch 3 times, most recently from 0758d95 to 23158c7 Compare December 4, 2024 01:12
docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
@a-ovchinnikov a-ovchinnikov force-pushed the issue635 branch 3 times, most recently from 31d131f to e62679f Compare December 5, 2024 17:04
Copy link
Contributor

@taylormadore taylormadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few structural ideas/comments/suggestions. Nothing major missing as far as I can tell

docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
Copy link
Member

@slimreaper35 slimreaper35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nitpicks, but overall it looks fine

docs/yarn_classic.md Show resolved Hide resolved
docs/yarn_classic.md Show resolved Hide resolved
docs/yarn_classic.md Outdated Show resolved Hide resolved
This commit introduces user-facing documentation for
Yarn Classic.

Signed-off-by: Alexey Ovchinnikov <[email protected]>
@a-ovchinnikov a-ovchinnikov added this pull request to the merge queue Dec 12, 2024
Merged via the queue into containerbuildsystem:main with commit d89b567 Dec 12, 2024
16 checks passed
@a-ovchinnikov a-ovchinnikov deleted the issue635 branch December 12, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants