Fix project files absolute paths when a work copy is used #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoapimentel
force-pushed
the
fix-work-copy-bug
branch
from
efd4d6e to
21750fc
Compare
taylormadore
approved these changes
Jan 20, 2025
brunoapimentel
force-pushed
the
fix-work-copy-bug
branch
from
21750fc to
53b846c
Compare
eskultety
reviewed
Jan 21, 2025
a-ovchinnikov
approved these changes
Jan 21, 2025
eskultety
approved these changes
Jan 21, 2025
To avoid unintended source code modifications, Cachi2 makes a copy of the source directory when some package managers are used (currently, it's being done just for yarn). This creates a problem with project files, since the absolute path of files now is pointing to the temporary working copy. The solution introced by this patch reverts these paths back to the original source dir path. This is intended to be a quick fix, and should only be kept until we solve containerbuildsystem#712. Signed-off-by: Bruno Pimentel <[email protected]>
brunoapimentel
force-pushed
the
fix-work-copy-bug
branch
from
53b846c to
83c043e
Compare
slimreaper35
approved these changes
Jan 21, 2025
Merged
via the queue into
containerbuildsystem:main
with commit Jan 21, 2025
06180db
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid unintended source code modifications, Cachi2 makes a copy of the source directory when some package managers are used (currently, it's being done just for yarn).
This creates a problem with project files, since the absolute path of files now is pointing to the temporary working copy. The solution introced by this patch reverts these paths back to the original source dir path.
This is intended to be a quick fix, and should only be kept until we solve #712.
Resolves #785.
Maintainers will complete the following section