Skip to content

Commit

Permalink
Remove no-op description from top-level tests
Browse files Browse the repository at this point in the history
Signed-off-by: apostasie <[email protected]>
  • Loading branch information
apostasie committed Oct 22, 2024
1 parent 07cb00b commit 0591862
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 13 deletions.
2 changes: 0 additions & 2 deletions cmd/nerdctl/image/image_convert_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func TestImageConvert(t *testing.T) {
nerdtest.Setup()

testCase := &test.Case{
Description: "Test image conversion",
Require: test.Require(
test.Not(test.Windows),
test.Not(nerdtest.Docker),
Expand Down Expand Up @@ -101,7 +100,6 @@ func TestImageConvertNydusVerify(t *testing.T) {
var registry *testregistry.RegistryServer

testCase := &test.Case{
Description: "TestImageConvertNydusVerify",
Require: test.Require(
test.Linux,
test.Binary("nydus-image"),
Expand Down
6 changes: 2 additions & 4 deletions cmd/nerdctl/image/image_list_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ func TestImages(t *testing.T) {
nerdtest.Setup()

testCase := &test.Case{
Description: "TestImages",
Require: test.Not(nerdtest.Docker),
Require: test.Not(nerdtest.Docker),
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("pull", "--quiet", testutil.CommonImage)
helpers.Ensure("pull", "--quiet", testutil.NginxAlpineImage)
Expand Down Expand Up @@ -133,8 +132,7 @@ func TestImagesFilter(t *testing.T) {
nerdtest.Setup()

testCase := &test.Case{
Description: "TestImagesFilter",
Require: nerdtest.Build,
Require: nerdtest.Build,
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("pull", "--quiet", testutil.CommonImage)
helpers.Ensure("tag", testutil.CommonImage, "taggedimage:one-fragment-one")
Expand Down
3 changes: 0 additions & 3 deletions cmd/nerdctl/image/image_pull_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ func TestImagePullWithCosign(t *testing.T) {
var keyPair *testhelpers.CosignKeyPair

testCase := &test.Case{
Description: "TestImagePullWithCosign",
Require: test.Require(
test.Linux,
nerdtest.Build,
Expand Down Expand Up @@ -107,7 +106,6 @@ func TestImagePullPlainHttpWithDefaultPort(t *testing.T) {
var registry *testregistry.RegistryServer

testCase := &test.Case{
Description: "TestImagePullPlainHttpWithDefaultPort",
Require: test.Require(
test.Linux,
test.Not(nerdtest.Docker),
Expand Down Expand Up @@ -150,7 +148,6 @@ func TestImagePullSoci(t *testing.T) {
nerdtest.Setup()

testCase := &test.Case{
Description: "TestImagePullSoci",
Require: test.Require(
test.Linux,
test.Not(nerdtest.Docker),
Expand Down
2 changes: 0 additions & 2 deletions cmd/nerdctl/image/image_push_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ func TestPush(t *testing.T) {
var registryNoAuthHTTPRandom, registryNoAuthHTTPDefault, registryTokenAuthHTTPSRandom *testregistry.RegistryServer

testCase := &test.Case{
Description: "Test push",

Require: test.Linux,

Setup: func(data test.Data, helpers test.Helpers) {
Expand Down
3 changes: 1 addition & 2 deletions cmd/nerdctl/image/image_save_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ func TestSaveContent(t *testing.T) {
nerdtest.Setup()

testCase := &test.Case{
Description: "Test content (linux only)",
Require: test.Not(test.Windows),
Require: test.Not(test.Windows),
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("pull", "--quiet", testutil.CommonImage)
},
Expand Down

0 comments on commit 0591862

Please sign in to comment.