Builder tests #3555
Merged
Builder tests #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
part7
branch
6 times, most recently
from
2559a76 to
ca872cb
Compare
apostasie
force-pushed
the
part7
branch
19 times, most recently
from
2379346 to
e212720
Compare
|
Failures are fixed by #3563 |
apostasie
commented
Oct 17, 2024
| // and adds cleanup steps to test cleanup. The builder name is returned as output. | ||
| // | ||
| // If not docker, this function returns an empty string as the builder name. | ||
| func SetupDockerContainerBuilder(t *testing.T) string { |
There was a problem hiding this comment.
This was used only once and could be simplified in the test in-place.
apostasie
commented
Oct 17, 2024
| @@ -43,7 +43,9 @@ const ( | |||
| NginxAlpineImage = "registry.k8s.io/e2e-test-images/nginx:1.14-2" | |||
| NginxAlpineIndexHTMLSnippet = "<title>Welcome to nginx!</title>" | |||
|
|
|||
| GolangImage = "fixme-test-using-this-image-is-disabled-on-windows" | |||
| GolangImage = "fixme-test-using-this-image-is-disabled-on-windows" | |||
There was a problem hiding this comment.
As we remove more of platform-specific test files and replace with platform-dependent t.Skip, we need a few placeholders so that we compile.
The point of this (as exposed ealier), is to make platform-specific skip/unskip easier than it is today.
Signed-off-by: apostasie <[email protected]>
ktock
approved these changes
Oct 18, 2024
|
Thanks a lot @ktock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focused solely on rewriting builder tests with the new test framework.
Any other changes (in testutil) are removal of no-longer used helpers, and making sure we can compile on other platforms as we make test files move away from _platform.go patterns.
Besides 1-1 rewrite, a few test changes are worth noting:
builder pruneop that was previously in place. The key upside is that tests can now be ran in parallel instead of sequentially, with no downside as far as I can tell (if there is any, we can always --no-cache where it matters)This PR has been reduced as much as feasible to not contain any other changes.
I know it is still big (1k lines)... - lmk if you think there is a good way to break this up.