Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround and document weird docker issue #3574

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

apostasie
Copy link
Contributor

Seen while debugging #3535

Not quite sure what is going on, but for now the workaround will do.

Tagging @thaJeztah in case there would be interest in investigating more.

@apostasie apostasie marked this pull request as draft October 18, 2024 20:18
@apostasie apostasie force-pushed the test-docker-workaround branch from a24e7f4 to 5609de3 Compare October 18, 2024 20:19
@apostasie apostasie mentioned this pull request Oct 18, 2024
@apostasie apostasie marked this pull request as ready for review October 18, 2024 20:47
@@ -36,6 +36,12 @@ func TestCommit(t *testing.T) {
helpers.Anyhow("rmi", "-f", data.Identifier())
},
Setup: func(data test.Data, helpers test.Helpers) {
// FIXME: short of pulling first, docker will fail to start the container.
// Debugging shows container exited immediately. Nothing in the container logs. Not much in journalctl.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you repro the issue without using the nerdctl test suite?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reported to https://github.com/moby/moby/issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does happen on #3535, but I cannot repro locally for now.

I believe it was previously hidden with retries.

I will report on moby if I manage to get a reproducer outside of the CI context.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea; haven't seen that issue. With the default pull policy ("missing"), the CLI should trigger a pull when the API endpoint returns a 404; https://github.com/docker/cli/blob/8a7c5ae68f42061fa3085736b91a9e831e0eab07/cli/command/container/create.go#L272-L289

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the pull was successful on run.
Totally spitballing: this might be a race issue with docker starting and starting a container?

@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Oct 18, 2024
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 18, 2024
@AkihiroSuda AkihiroSuda merged commit 7ab9155 into containerd:main Oct 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants