Add new requirements (HyperV, CgroupsAccessible) #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Oct 22, 2024
apostasie
force-pushed
the
series-5
branch
2 times, most recently
from
decf278 to
03431c8
Compare
apostasie
changed the title
|
@AkihiroSuda is there a way to scale-up the arm64 instance? |
AkihiroSuda
reviewed
Oct 22, 2024
| var dinf dockercompat.Info | ||
| err := json.Unmarshal([]byte(stdout), &dinf) | ||
| assert.NilError(helpers.T(), err, "failed to parse docker info") | ||
| return dinf.CgroupVersion == "2", "we are rootless, and cgroup version is not 2" |
There was a problem hiding this comment.
You may also want to check that CgroupDriver == "systemd"
There was a problem hiding this comment.
Ok, will have a look.
Travelling currently - will be slow to answer.
nerdctl/.github/workflows/test.yml Line 72 in beaa39d Looks like we also have |
Signed-off-by: apostasie <[email protected]>
Ok, will look. |
AkihiroSuda
approved these changes
Oct 23, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding new
requirementsnecessary for upcoming tests rewrites.