-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeouts on CI #3726
Increase timeouts on CI #3726
Conversation
Signed-off-by: apostasie <[email protected]>
fbbb496
to
e536ed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Thanks @djdongjin Just increased ipv6 test as well. Not sure if GH slowness is transient or not, but either way we need a bit of leeway and I did set these timeouts too aggressive in the first place. |
Ok... something is very wrong with GH right now... https://github.com/containerd/nerdctl/actions/runs/12150865305 |
@djdongjin there definitely was some transient issue with github causing a bunch of timeouts. I still think relaxing the timeouts a bit on these is warranted and will not hurt anyhow (windows normally clocks in at 4min+, quite close to the current 5 mins limit), so, let's merge if you are ok with that. |
is the execution engine (e.g. Docker) that runs these jobs using the maximum CPU/memory available on the machine ? we will reach a limit with the timeout :/ |
Not sure. I will have a look around. About that, I have mixed feelings about the fact that we are running tests inside a docker container overall:
I know we do that for a reason (provide environment consistency and reproducibility), but it comes at a cost ^. |
https://github.com/containerd/nerdctl/pull/3726/checks#step:3:87 docker info reports 4 CPU 16GB. Is there somewhere else dockerd could constrain containers resources that would not show in docker info? |
Either GH is busier or they downgraded the base instances we are using.
One way or the other:
@AkihiroSuda @djdongjin at your convenience.