Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: import cleanup #3728

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Chore: import cleanup #3728

merged 2 commits into from
Dec 4, 2024
+110 −110

Conversation

apostasie
Copy link
Contributor

Suggesting we remove spurious prefixes for imports that make reading code more confusing than necessary:

  • remove gocni, and use the expected cni
  • remove gocontext, and use the expected context

@apostasie
gocni -> cni
775a005 
Signed-off-by: apostasie <[email protected]>
@apostasie
gocontext -> context
f914ea3 
Signed-off-by: apostasie <[email protected]>
@apostasie apostasie marked this pull request as ready for review December 4, 2024 05:45
fahedouch
fahedouch approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

AkihiroSuda
AkihiroSuda approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.0.2 milestone Dec 4, 2024
@AkihiroSuda AkihiroSuda merged commit 03f0862 into containerd:main Dec 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahedouch fahedouch fahedouch approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@apostasie @AkihiroSuda @fahedouch