fix: Corrected description of containerd_address from GRPC to ttrpc #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaita Nakamura <[email protected]>
Mossaka
previously approved these changes
Feb 14, 2025
Mossaka
reviewed
Feb 14, 2025
| @@ -22,7 +22,7 @@ pub struct InstanceConfig { | |||
| bundle: PathBuf, | |||
| /// Namespace for containerd | |||
| namespace: String, | |||
| // /// GRPC address back to main containerd | |||
| /// GRPC address back to main containerd | |||
There was a problem hiding this comment.
technically this should be a ttrpc address
There was a problem hiding this comment.
Hmm, I think this is indeed the grpc address. The one that the wasm-oci code uses to talk back with c8d.
IIRC, this is /var/containerd/containerd.sock, while the ttrpc socket is /var/containerd/containerd.sock.ttrpc
There was a problem hiding this comment.
Ah yes you're right! I merged this PR in but we can revert it back
Signed-off-by: Kaita Nakamura <[email protected]>
z63d
changed the title
Mossaka
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably a mistake.