tracing: add parameters info to the trace instead of skipping them #853
+102
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit also removes 'parent = ...' since it's already in the default Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- crates/containerd-shim-wasmtime/src/instance.rs: Evaluated as low risk
- crates/containerd-shim-wasm/src/sandbox/shim/task_state.rs: Evaluated as low risk
- crates/containerd-shim-wasm/src/sandbox/instance.rs: Evaluated as low risk
- crates/containerd-shim-wasm/src/sandbox/instance_utils.rs: Evaluated as low risk
- crates/containerd-shim-wasm/src/sys/unix/metrics.rs: Evaluated as low risk
- crates/containerd-shim-wasm/src/sandbox/cli.rs: Evaluated as low risk
- crates/containerd-shim-wasm/src/sandbox/shim/cli.rs: Evaluated as low risk
Comments suppressed due to low confidence (1)
crates/containerd-shim-wasm/src/sys/unix/container/executor.rs:48
- The error message 'CantHandle' is unclear. Consider providing more context about why the executor cannot handle the container.
InnerExecutor::CantHandle => Err(LibcontainerExecutorError::CantHandle(E::name())),
|
What is, if any, the impact on performance? |
From the benchmarks, I can hardly see much negative impact on performance: https://github.com/containerd/runwasi/actions/runs/13321128097?pr=853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit also removes 'parent = ...' since it's already in the default
Notice how
version,revision, andnameare now included in the tags.