Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google search-console to the list of domains #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vimode
Copy link

@vimode vimode commented Oct 25, 2023

This PR adds a new domain to the list of Google Services and respects Ignore search pages option too that will cause a conflict because of this new addition.

search.google.com/search-console is a google services domain for webmasters
I didn't add it as search.google.com because that redirects to google homepage.

As per the current behavior any pathname that starts with /search will be included in ignore or allow list based on the user preference of Ignore search pages as the new domain's pathname starts with /search

So this fix to the isSearchpageURL makes sure that its
a) pathname exactly matches /search
b) has something in search params.

Closes #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"Ignore search pages" also ignores Search Console
1 participant