coredns: request must return both IPv6 and IPv4 for recordtype ANY
#250
Conversation
|
/hold this needs dedicated tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Aardvark-dns must return both `IPv6` and `IPv4` if the DNS request has record type `ANY` instead of `A` or `AAAA` record type. Closes: containers#249 Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
resolver-any-request
branch
from
3adb5f6
to
85ddddb
Compare
|
@flouthoc: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@flouthoc What is the state here? Can you add a test? |
|
@flouthoc ping, is still still wanted? |
|
@Luap99 Not wanted by anybody but I just found it while playing, let me see if i can still repro this and the patch fixes the issue or not, I think there were some edgecase which i was hitting last time playing with this. |
Nextcloud is doing ANY requests. I don't know if this is something they should fix on their end, but since other resolvers return A and AAAA records on ANY requests, I'd say this fix is needed. |
|
There are actually to issues. The first one is resolved with this PR. The second is aardvark-dns not being bound to TCP and that ANY queries are going through TCP by default. |
Aardvark-dns must return both
IPv6andIPv4if the DNS request has record typeANYinstead ofAorAAAArecord type.Closes: #249