[WIP] observability with bootc example (kepler & opentelemetry-collector) #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sallyom <[email protected]>
sallyom
requested review from
MichaelClifford,
rhatdan,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
frzifus
reviewed
Jul 11, 2024
| extensions: | ||
| file_storage: | ||
| # this dir must exist on filesystem where otelcollector is running | ||
| directory: /etc/otelcol-logs |
There was a problem hiding this comment.
Isnt there a better place for cached data? AFAIK /var should be mutable? Maybe we can use something like /var/cache/opentelemetry-collector/? wdyt?
There was a problem hiding this comment.
Yes lets treat /usr and /etc as read-only from apps point of view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PoC for adding observability (Kepler and OpenTelemetry Collector) to a bootc system. Not specific to AI workloads so not sure it belongs in this repo, but if everyone running AI workloads requires an observability solution, than perhaps it does belong here.