Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix variable naming conventions #839

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix variable naming conventions #839

merged 1 commit into from
Jan 8, 2025

Conversation

Gregory-Pereira
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira commented Jan 7, 2025 •
edited
Loading

This was found during #834. Naming and tagging conventions should be consistent

rhatdan
rhatdan approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 52f7c72 into containers:main Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooktheryan cooktheryan cooktheryan approved these changes

@rhatdan rhatdan rhatdan approved these changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@sallyom sallyom Awaiting requested review from sallyom sallyom is a code owner

@lmilbaum lmilbaum Awaiting requested review from lmilbaum

@cgwalters cgwalters Awaiting requested review from cgwalters cgwalters is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gregory-Pereira @rhatdan @cooktheryan