Utilize the new library timebomb() function. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevich
added
no_skopeo_cidev
cevich
force-pushed
the
use_library_timebomb
branch
from
e5c34e5 to
014723a
Compare
cevich
commented
Jan 26, 2024
|
This needs containers/automation#175 |
cevich
removed
no_skopeo_cidev
cevich
removed
no_fedora-podman-aws-arm64
cevich
force-pushed
the
use_library_timebomb
branch
from
014723a to
0bfd9b2
Compare
cevich
changed the title
cevich
force-pushed
the
use_library_timebomb
branch
4 times, most recently
from
68e8b2f to
6366f5a
Compare
|
Cirrus CI build successful. Found built image names and IDs:
|
N/B: This new automation library version includes a significant update to stdio redirection for all functions. Careful testing of these images is highly recommended. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
use_library_timebomb
branch
from
6366f5a to
7d01036
Compare
|
Cirrus CI build successful. Found built image names and IDs:
|
|
OOH! New rawhide kernel! @containers/podman-maintainers this is super-critical-important, we need to get this into podman CI to see if the hang goes away. (Unfortunately this build is broken, bad netavark, so we can't use these VMs. But next week this will be my first priority)
|
|
Code LGTM from the perspective of "fine with me to check in", but ABSOLUTELY DO NOT USE THESE VMS ANYWHERE. Just to be clear. (The debian |
edsantiago
reviewed
Feb 15, 2024
| @@ -194,12 +194,6 @@ DOWNLOAD_PACKAGES=(\ | |||
| msg "Installing general build/test dependencies" | |||
| bigto $SUDO dnf install -y "${INSTALL_PACKAGES[@]}" | |||
|
|
|||
| timebomb 20240214 "Gaaaaaaaaah! Kludge to emergency-get netavark 1.10.3" | |||
There was a problem hiding this comment.
....or, @cevich, if you don't mind bumping this timebomb to 20240217 and respinning, that could possibly be super-duper-helpful in tracking down the hang.
There was a problem hiding this comment.
As in, bumping it and reinstating it because netavark is still testing and not stable.
This PR could serve that purpose. It's going to need running through at least podman CI to confirm all the stdio redirect changes don't break anything. I don't plan on touching this in any serious way until next week anyway. |
|
Followup:
LGTM to merge. |
|
okay thanks. And if you're building again next week, we can leave the >>stdio>> testing to then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N/B: This new automation library version includes a significant update
to stdio redirection for all functions. Careful testing of these images
is highly recommended.