Drop podman host exec #945
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What we're doing here is a bit gross because while we're changing the mountns, other things (especially networking) will be inherited from our container, creating an ill-defined mess. If we do need true host code execution then we should actually use systemd-run or so. But we don't need that here - now that we've been automatically ensuring the `/var/lib/containers` mount, we can use the version of podman in the container image here. Signed-off-by: Colin Walters <[email protected]>
Right now we depend on both in general (the ostree-container side uses skopeo, the logically bound images use podman), but today LBIs are a "soft" dependency. Let's use skopeo here for consistency. Signed-off-by: Colin Walters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib: Drop usage of hacky run_in_host_mount_ns
What we're doing here is a bit gross because while we're
changing the mountns, other things (especially networking)
will be inherited from our container, creating an ill-defined
mess. If we do need true host code execution then we should
actually use systemd-run or so.
But we don't need that here - now that we've been automatically
ensuring the
/var/lib/containersmount, we can use the versionof podman in the container image here.
Signed-off-by: Colin Walters [email protected]
install: Use skopeo instead of podman
Right now we depend on both in general (the ostree-container side uses
skopeo, the logically bound images use podman), but today LBIs are
a "soft" dependency.
Let's use skopeo here for consistency.
Signed-off-by: Colin Walters [email protected]