Handle RUN --mount with relative targets and no configured workdir #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/bug
nalind
force-pushed
the
mounts-implicit-workdir
branch
from
3a001da
to
fa452a1
Compare
Luap99
reviewed
Oct 30, 2024
tests/bud.bats
Outdated
| echo RUN --mount=type=bind,src=Containerfile,target=Containerfile pwd >> ${TEST_SCRATCH_DIR}/Containerfile | ||
| echo RUN --mount=type=cache,target=cachesubdir pwd >> ${TEST_SCRATCH_DIR}/Containerfile | ||
| echo RUN --mount=type=tmpfs,target=tmpfssubdir pwd >> ${TEST_SCRATCH_DIR}/Containerfile | ||
| run_buildah build ${TEST_SCRATCH_DIR} |
There was a problem hiding this comment.
I feel like this should actually verify that these mounts are actually mounted at the proper expected target?
nalind
force-pushed
the
mounts-implicit-workdir
branch
from
fa452a1
to
1f91b7a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
When the target location of a RUN --mount is specified as a relative path, we normally try to convert it to an absolute path by combining it with the currently-configured working directory. If there is no such value, though, the result is still not an absolute path. Work around this by using "/" when the configured working directory is "". Set this field in the `runMountInfo` struct on FreeBSD, as we already did on Linux. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
mounts-implicit-workdir
branch
from
1f91b7a
to
701d6bb
Compare
|
Rebased. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 0787ba6
into
containers:main
31 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the target location of a RUN --mount is specified as a relative path, we normally try to convert it to an absolute path by combining it with the currently-configured working directory. If there is no such value, though, the result is still not an absolute path. Work around this by using "/" when the configured working directory is "".
Set this field in the
runMountInfostruct on FreeBSD, as we already did on Linux.How to verify it
New integration test!
Which issue(s) this PR fixes:
Fixes #5738
Special notes for your reviewer:
Does this PR introduce a user-facing change?