Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/tools: update golangci-lint to v1.61.0 #5821

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 7, 2024

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

As I used this locally and the binaires already existed make did not
rebuild. While we could list all go files here nobody should be
modifying files under vendor/ directly so just checking go.mod/sum seems
easiest.

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this pull request Nov 7, 2024
@Luap99
Copy link
Member Author

Luap99 commented Nov 7, 2024

@nalind @rhatdan PTAL

@rhatdan
Copy link
Member

rhatdan commented Nov 7, 2024

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 7, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
@nalind
Copy link
Member

nalind commented Nov 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d655c58 into containers:main Nov 7, 2024
32 checks passed
@Luap99 Luap99 deleted the lint branch November 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants