Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: add ppc64le and s390x targets for podman-next copr #275

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 22, 2023

Reusing of targets from epehemeral copr build isn't working well for now.
We can revisit target specification once F37 goes EOL.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lsm5
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@packit-as-a-service
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team.

1 similar comment
@packit-as-a-service
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team.

Reusing of targets from epehemeral copr build isn't working well for now.
We can revisit target specification once F37 goes EOL.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the packit-enable-arches branch from a6d6fc9 to 29f6420 Compare September 22, 2023 12:35
@lsm5 lsm5 marked this pull request as ready for review September 22, 2023 12:36
@lsm5
Copy link
Member Author

lsm5 commented Sep 22, 2023

@cfergeau @baude PTAL

@@ -16,8 +16,7 @@ jobs:
- job: copr_build
trigger: pull_request
enable_net: true
# keep in sync with https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next
targets: &copr_targets
targets:
- fedora-rawhide-aarch64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ppc64le/s390 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so ppc64le/s390x builds take really long to complete. Adding them on trigger: pull_request would PRs could take forever to merge. That's why I've only added them to trigger: commit.

@lsm5
Copy link
Member Author

lsm5 commented Sep 22, 2023

@cfergeau good to go. We need this to unblock https://cirrus-ci.com/task/5667616522502144

@lsm5
Copy link
Member Author

lsm5 commented Sep 22, 2023

merging this to get the multi arch image builds unblocked. Doesn't affect upstream and packit tasks on PR, so it's safe.

@lsm5 lsm5 merged commit 97028a6 into containers:main Sep 22, 2023
17 checks passed
@lsm5 lsm5 deleted the packit-enable-arches branch September 22, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants